Skip to content
Snippets Groups Projects

Disable minecart spawners for players already riding a minecart

Merged Tatsuru requested to merge Tatsuru/SRB2:minecartspawner-fix into next
All threads resolved!

This had the consequence of new minecarts spawning on already riding players, which caused the previous ones to kill the players riding them even when they hit a stopper. toaster said this wasn't important and also unintended behavior so it's completely gone now :)

Merge request reports

Checking pipeline status.

Approval is optional

Merged by avatar (May 4, 2025 8:02am UTC)

Merge details

  • Changes merged into with bd0deea1.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tatsuru added 1 commit

    added 1 commit

    Compare with previous version

  • Not that it particularly matters, but you could have used a single line to get the same effect:

    if (!player->bot && special->fuse <= TICRATE && player->powers[pw_carry] != CR_MINECART)
  • Author Maintainer

    Funnily enough that was my initial fix for the issue before I talked to toaster about it but I got temporarily confused about what she intended initially d: I'm amending it again because that's cleaner

  • Tatsuru added 1 commit
  • James R. resolved all discussions

    resolved all discussions

  • It looks like you added some whitespace. Seems fine elsewise.

  • Contributor

    Yeah, whitespace deletion necessary before merger but this otherwise has my thumbs up

  • Tatsuru added 1 commit

    added 1 commit

    Compare with previous version

  • merged

  • James R. mentioned in commit bd0deea1

    mentioned in commit bd0deea1

  • Please register or sign in to reply
    Loading