Fix CLEAR! signpost showing up in unmodded games (& add proper support for SPR2 animated signpost)

p_enemy.c: In function 'A_SignPlayer':
p_enemy.c:5235:25: error: comparison of integer expressions of different signedness: 'int' and 'statenum_t' {aka 'const enum state'} [-Werror=sign-compare]
 5235 |    if (ov->state-states != actor->info->seestate)
      |                         ^~
p_enemy.c:5242:25: error: comparison of integer expressions of different signedness: 'int' and 'statenum_t' {aka 'const enum state'} [-Werror=sign-compare]
 5242 |    if (ov->state-states != actor->info->missilestate)
      |                         ^~
p_enemy.c:5250:24: error: comparison of integer expressions of different signedness: 'int' and 'statenum_t' {aka 'const enum state'} [-Werror=sign-compare]
 5250 |   if (ov->state-states != actor->info->meleestate)
      |                        ^~

Breaks 32 bit builds

Why does that happen sometimes and not other times? In p_user.c I've never needed to cast to statenum_t.

added 1 commit

• 248a80ca - Cast to statenum_t for 32-bit compatibility

Compare with previous version

Enums can be signed or unsigned, that depends on the compiler and values in it

I see - but specifically, why doesn't it error when comparing to a statenum_t directly? (Such as here: https://git.magicalgirl.moe/STJr/SRB2/blob/master/src/p_user.c#L2291)

removed Bruh moment label

merged

mentioned in commit 9498c5ba