Skip to content
Snippets Groups Projects

Remove faulty code from T_MovePlane()

Merged Nev3r requested to merge t_moveplane-refactor into next

T_MovePlane()'s code block at the end makes some exceptions to supposedly handle MT_SPINFIRE, MT_SPIKE and MT_GOOP's height properly, however this exceptional handling has proven to be useless at most, and faulty in some cases. While glitch-rocketing spikes up into the air sounds hilarious, I consider the behavior to be undesirable. This merge request removes the faulty code as well as the related line_t.tagline pointer as it served no other purpose.

2.2.2: srb20183

This branch: srb20184

Edited by Nev3r

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nev3r changed the description

    changed the description

  • Nev3r changed target branch from master to next

    changed target branch from master to next

  • Nev3r changed title from Remove presumably useless code from T_MovePlane() to Remove faulty code from T_MovePlane()

    changed title from Remove presumably useless code from T_MovePlane() to Remove faulty code from T_MovePlane()

  • Author Contributor

    I will note a behavior change, which involves quicksand: In 2.2.2, spikes placed on a quicksand surface will remain on a surface indefinitely until another surface comes out of the quicksand and "picks" them up, after that, the spikes will stick to said surface:

    srb20186

    In this branch, the spikes remain on the surface of the quicksand no matter what:

    srb20187

    CEZ1's mud spikes seem to be unaffected by this change.

    Edited by Nev3r
  • Nev3r added 1 commit

    added 1 commit

    • 01c0797b - Remove now unused P_MobjReadyToMove().

    Compare with previous version

  • IIRC the original code was made to fix a bug reported way back in 2.0 involving quicksand: https://mb.srb2.org/showthread.php?t=33772 (unfortunately the image no longer works, but the level in question lowered the quicksand after a boss fight against Egg Slimer, and the slimes stayed floating in midair even though the quicksand was gone; also hi I made the level)

  • merged

  • Nev3r mentioned in commit 464ecc01

    mentioned in commit 464ecc01

Please register or sign in to reply
Loading