Skip to content
Snippets Groups Projects

Delete polyobjects

Merged MascaraSnake requested to merge remove-polyobjects into next
Edited by MascaraSnake

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • The merge request should be named "Delete polyobjects", not "Remove polyobjects".

    I am sorry, but as it happens I have no other choice but to downvote this.

  • MascaraSnake changed title from Remove polyobjects to Delete polyobjects

    changed title from Remove polyobjects to Delete polyobjects

  • Author Contributor

    Closing this MR because of -2.

  • MascaraSnake mentioned in merge request !912 (merged)

    mentioned in merge request !912 (merged)

  • I yet another time deeply suggest giving another thought as to whether or not the removal of a feature which happens to already be utilized multiple times throughout even the unmodified vanilla game's levels themselves is something that should be done for a patch upgrade rather than a major release, as it is most clearly a thing of which can break backwards-compatibility with existing levels, vanilla or not, as well as any replays recorded within Record Attack or demos recorded otherwise that interact with said feature.

    I can attest to that decreasing the amount of unintended and undefined behaviour should most certainly be one of the goals of post-major-release patches, like I can also attest to that PolyObjects may regularly show signs of similarly unintended and undefined behaviour, but it is of my own personal belief that time would be considerably better spent improving upon the existing PolyObject code or even recreating it all over from scratch, and I would sincerely hope that you are of the same opinion. Even in the case that the latter option is what this is in preparation of, I would still advice instead waiting until it is complete so that it may be merged in at the same time as the removal of the old code, so that complete PolyObject downtime may be avoided in the first place.

  • merged

  • MascaraSnake mentioned in commit b8a9686a

    mentioned in commit b8a9686a

Please register or sign in to reply
Loading