Skip to content
Snippets Groups Projects

Compile fixes for buidbots

Merged mazmazz requested to merge mazmazz_/SRB2:SRB2-CHAT-COMPILE into SRB2-CHAT

A few changes to variable declarations so that the buildbots are happy:

  • Unsigned var vs. signed var comparisons -- changed some signed ints to unsigned
    • I'm pretty sure this is safe from overflow. The affected vars already check for <= 0 so that they're prevented from overflowing.
  • Mixed D&C -- move declarations to top of code blocks
  • Some int changed to INT32
    • This one doesn't really matter -- there are a few places in code where int is used -- but it helps portability for other architectures.
  • Fix strncpy(nodenum, msg+3, 5) calls so that the copy length (5) does not overflow the malloc size of nodenum (3)

Buildbot result before this merge:

Buildbot result ater this merge:

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Also, curious why HU_DrawTeamTabRankings() is in the branch? I'd recommend removing that for the MR, as well as any other non-vanilla code that's not essential to CHAT.

  • The Tab Ranking functions got a little extra ping display next to each player icon (The values displayed there are the same as if you checked with the ping command), as well as an option for a compact tab rankings that can actually display 32 players. It was gonna be stated in the MR as general quality of life improvements but I can remove those if it's a problem. Also, thank for the fixes, I appreciate it!

  • merged

  • Latapostrophe mentioned in commit 9c9fd2e2

    mentioned in commit 9c9fd2e2

  • Fair, I guess I don't mind as long as MI doesn't either :slight_smile: will await the MR

  • also I didn't code menu disabling, but I'll let it slide because there's more pressing tasks. The menu stuff is good to go as-is IMO.

Please register or sign in to reply
Loading