Callmore authored 10 months ago and Eidolon committed 10 months ago

This fixes an oversight with pwrlv average calculation that causes
the total to overflow with enough players or high enough pwrlv.
Hopefully this might fix that bug where pwrlv is shown as negative
on the server select menu.

Maintainer note: This is still imprecise but it fixes the overflow
without potentially disrupting game code.

The hypothesis for this patch is that the operating system has not actually
finished writing the file to disk when moving the tmp file into place. The
move operation is atomic, but the write is not, even when flushed or using
unbuffered IO. So we reorder these operations, make the old save .bak
atomically and write the new save in place.

I doubt saving this backup will actually be useful given the frequency of
saves in the game, but at the very least it leaves _some_ backup in place in
the event of failure.

Like with position bulbs, the position number takes a large portion of
the screen and flashes rapidly. This slows that rate to 25% of what it
is when Reduce VFX is off.

Fixes ERRORMODE compliation after !2372

In green resolutions, especially past 12 players, these bulbs take up a
large part of the screen and flash in a particularly intense way for
people with heightened photosensitivity. This disables the animations
while still presenting them effectively.

- Don't apply mindelay to clients that are already slower than their mindelay, WTF
- Don't double apply mindelay to hosts to compensate for the above, WTF

It's scary that it wasn't doing this before!

Make the amount to darken based on how light/dark the area already was. This prevents it from making dark areas pitch black.

Since there are less crashes than ever before, and there are risks
with trying to do anything inside a signal handler beyond the most
basic recovery stuff, we should avoid doing *anything* in here.

blame 4c9b9f0e