Set GS_LEVEL after level load, set GS_WAITINGFORPLAYERS during level transition if GS_LEVEL is current GS

I got so mad about this I brought the fix to v1 also

toaster authored 7 years ago and James R. committed 4 years ago

(cherry picked from commit 7556b407b247a9bfb9420781b8fa1ac4facce07d)

Fixes a crash that can happen when starting RA attempts if you press
keys/buttons that would cancel a netgame connection

If the join secret isn't ready right away, wait for the next update instead of trying to loop for it again immediately

I believe this may be the cause of the invite crash some people have noticed in master, but I'm not sure, needs tested.

This allows the final exe to use more than 2gb of RAM in a 64-bit system
which should get rid of most out of memory errors on 32-bit builds

If the game is paused, music will be resumed when unpause anyway.

Now FixedHypot uses the code from R_PointToDist2, and R_PointToDist2 just calls FixedHypot.

Ultimately, this branch was intended to get rid of a redundant way to retrieve distance and replace it with the one that was actually good at its job. So consolidating FixedHypot and R_PointToDist2 together is just an extension of that.

Apparently overflows less often

Not convinced that the small speed benefit from P_AproxDistance is worth the "aproximate"[sic] results it gives. Let's instead try a define to replace it with FixedHypot. In Lua, the function gives a deprecated warning.

Inspired by the hyperwall fix for vanilla, except for everything. From little testing, actively improves waypoint checks, bumping, speed checks, wall collisions, Jawz targetting, Lightning Shield attacks, so on.

The only way I see this as a potential downgrade is A_Look (and related functions) getting slower, which are barely used in Kart.

Changes from 58dd578b094639405d452593562e0f8cb2b482ce,
a36920808b74e068d582dda5a3b75bdf64246463,
41c902b819ac8fdef173c4ba76a8c50ad8107190,
60928db0e0b08fee7ceddd5515adf2246bb655c3.

CV_SetValue merged with CV_Set (same with CV_StealthSetValue and CV_StealthSet).

LJ Sonic authored 4 years ago and James R. committed 4 years ago

Careful! Both are local variables and are always false for clients,
and therefore should obviously not be used in anything gamelogic-related.

The worst part is you could've just saved the player userdata and accessed it
later anyway while player.mo is nil.