Not needed in K_UpdateGrandPrixBots or
K_LoadGrandPrixSaveGame because P_SpawnPlayer takes
priority.

- G_AddPlayer now contains CL_ClearPlayer, G_DestroyParty, and playeringame set
- Instead of a nasty, complicated block in P_SpawnPlayer, externalise it into G_SpectatePlayerOnJoin
- All mid-game human player-to-spectator transitions are handled by P_SetPlayerSpectator, instead of lots of `spectator = true` and associated boilerplate
    - Simplifies Got_Teamchange MASSIVELY
        - Of course this is helped by also stripping back team change
    - This is called by P_KillPlayer, too
- P_KillPlayer no longer eats DMG_SPECTATOR when lightsnaking or exiting
- G_GametypeHasSpectators condition tidied

James R. authored 1 year ago and toaster committed 1 year ago

Fixes player death not ending a Prisons round, bugged
debug feature.

Now, do it properly. Don't end the round if the last
player spectates.

This is more than a debug feature; in Free Play, it lets
the player spectate and fly around if they want to, and
even come back in, all without restarting the level.

Refactor cvar definitions completely, move everything to cvars.cpp

See merge request KartKrew/Kart!1422

Dialogue 2

See merge request KartKrew/Kart!1421

Cheats menu on the pause menu

See merge request KartKrew/Kart!1424

Automatically populated with every cheat cvar.

- No need to call CV_RegisterVar
- Cvar definitions live in only one file, easier to locate
- Organized into sections -- netvars, cheats, etc.
- Use builder pattern to initialize cvars
- Still need to extern if you want to read the cvar value

- respawnitem
- respawnitemtime
- respawndelay
- startinglives

Separate script args from mapthing args

See merge request KartKrew/Kart!1405

Add server join splash (resolves #266)

Closes #266

See merge request KartKrew/Kart!1423

- Continue showing up on main in-game pause menu
- Flip to top half of screen, to avoid conflict with Round Queue
- Show over most UI, including menu

Auto Roulette (resolves #618)

Closes #618

See merge request KartKrew/Kart!1411

Probably doesn't matter, but it satisfies my OCD better

Just wanted to give literally any possibility of seeing the server contact as a client

Someone just needs to put an actual sound for it in sounds.pk3

We're in Undertale

- Slide in from top
- Fix chaining multiple dialogues with the same speaker not working
- Unset when changing level
- Sped up punctuation pause a bit

Remove some unused code

See merge request KartKrew/Kart!1420

Spraycans

Closes #609

See merge request KartKrew/Kart!1419

M_AssignSpraycans: Forgot to remove an irrelevant check, now should update if new Spray Can conditions are added

The prepended colour list passed to M_Shuffle_UINT16 was off by one, leading to possible pollution of the region with an uninitialised value.

For some reason, some people's machines guarantee clean stack memory on game startup, while other people's do not. This is why some people were crashing on Spray Can list generation and some weren't.

The stack memory was DEFINITELY not clean by the time you could navigate to the gamedata clear menu, which is why that was crashing without fail.

- growmusicfade
- invincmusicfade
- music_resync_powerups_only
- music_resync_threshold
- renderstats (wasn't even registered in the console!)
- resetspecialmusic
- resume
- samplerate
- stretch
- tailspickup

Just in case I don't get to do a major pass on adding a ton of extra unlockable conditions later, this is an easy, quick add featuring a stat gamedata and the statistics menu has been tracking for a while.