src/hu_stuff.c

@@ -641,6 +641,8 @@ static void Got_Saycmd(UINT8 **p, INT32 playernum)
 	msg = (char *)*p;
 	SKIPSTRINGL(*p, HU_MAXMSGLEN + 1);
 
+	// check if player is sending a say command while muted
+	// or if they are sending a csay and are not an admin
 	if ((cv_mute.value || flags & (HU_CSAY|HU_SERVER_SAY)) && playernum != serverplayer && !(IsPlayerAdmin(playernum)))
 	{
 		CONS_Alert(CONS_WARNING, cv_mute.value ?
@@ -680,6 +682,7 @@ static void Got_Saycmd(UINT8 **p, INT32 playernum)
 		stop_spamming[playernum] = 4; // you can hold off for 4 tics, can you?
 
 	// run the lua hook even if we were supposed to eat the msg, netgame consistency goes first.
+	// bitten's note: look into this if bugs can occure from this
 
 	if (LUA_HookPlayerMsg(playernum, target, flags, msg))
 		return;
@@ -711,6 +714,7 @@ static void Got_Saycmd(UINT8 **p, INT32 playernum)
 	// Clean up message a bit
 	// If you use a \r character, you can remove your name
 	// from before the text and then pretend to be someone else!
+	// bitten's note: i need to look into this, but you could just use \n to the same effect, why just filter \r
 	ptr = msg;
 	while (*ptr != '\0')
 	{

src/netcode/net_command.c

@@ -39,7 +39,8 @@ void RegisterNetXCmd(netxcmd_t id, void (*cmd_f)(UINT8 **p, INT32 playernum))
 
 void SendNetXCmd(netxcmd_t id, const void *param, size_t nparam)
 {
-	if (localtextcmd[0]+2+nparam > MAXTEXTCMD)
+	// +1 for the size and another +1 for the ID.
+	if (localtextcmd[0] + 2 + nparam > MAXTEXTCMD)
 	{
 		// for future reference: if (cv_debug) != debug disabled.
 		CONS_Alert(CONS_ERROR, M_GetText("NetXCmd buffer full, cannot add netcmd %d! (size: %d, needed: %s)\n"), id, localtextcmd[0], sizeu1(nparam));
@@ -57,7 +58,8 @@ void SendNetXCmd(netxcmd_t id, const void *param, size_t nparam)
 // splitscreen player
 void SendNetXCmd2(netxcmd_t id, const void *param, size_t nparam)
 {
-	if (localtextcmd2[0]+2+nparam > MAXTEXTCMD)
+	// +1 for the size and another +1 for the ID.
+	if (localtextcmd2[0] + 2 + nparam > MAXTEXTCMD)
 	{
 		I_Error("No more place in the buffer for netcmd %d\n",id);
 		return;