Discord Invite Fixes + DUMPCONSISTENCY flag for makefile
DUMPCONSISTENCYto be a flag that can be set in make.
DUMPCONSISTENCYcan be more helpful for throughout netgame desync debugging than
-consisdump, and having both choices available would not hurt anybody.
- Fixed faulty Discord invite/ask for join behaviour (makes invites for Linux work, as they were previously unsupported).
self_ipnow only copies
address, as the previous behaviour caused a buffer overflow in Linux.
addressalso has the server port, meaning that appending
current_port(which was the player's port, and not the servers') was not needed.
joinSecretnow directly gets the mangled address. Before, it got a reference to
xorjoinwhich would then be cleared from memory, leading to undefined behaviour.
Tested in Linux and Windows. MacOS should also benefit from these fixes, but it is untested there.
Let me know if anything needs changing.