Discord Invite Fixes + DUMPCONSISTENCY flag for makefile

JugadorXEIrequested to merge
JugadorXEI/Kart-Public:small-fixes-jug into master
  • Allow DUMPCONSISTENCY to be a flag that can be set in make. DUMPCONSISTENCY can be more helpful for throughout netgame desync debugging than -consisdump, and having both choices available would not hurt anybody.
  • Fixed faulty Discord invite/ask for join behaviour (makes invites for Linux work, as they were previously unsupported).
  • self_ip now only copies address, as the previous behaviour caused a buffer overflow in Linux. address also has the server port, meaning that appending current_port (which was the player's port, and not the servers') was not needed.
  • joinSecret now directly gets the mangled address. Before, it got a reference to xorjoin which would then be cleared from memory, leading to undefined behaviour.

Tested in Linux and Windows. MacOS should also benefit from these fixes, but it is untested there.

Let me know if anything needs changing.

Merge request reports