Skip to content
Snippets Groups Projects

Fix use-after-frees around mobjs

Merged X.organic requested to merge X.organic/Kart-Public:mobj-after-free into master

Fixes a series of use-after-frees related to mobjs. Most notably, makes R_RemoveMobjInterpolator properly remove the last item of interpolated_mobjs, and fixes every place where target, tracer, hnext or hprev were modified without proper reference counting – including one in p_saveg.c.

A notable use-after-free that this fixes is one that happens when a player spectates. While I cannot test this myself, I have heard that spectating mid-race can cause desyncs – this has a good chance of fixing them.

Edited by X.organic

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading