Allow players to change chosen colour while moving

Removes the P_PlayerMoving check in function Color_OnChange, allowing players to change their chosen colour in free play without needing to stop moving in-game first. This is especially useful for players who use commands to manage their character setup.

changed the description

Blocking midrace color changes is correct and intentional IMO (otherwise the code wouldn't be there!)—midrace color binds are annoying and harm gameplay readability.

With team signoff, I would merge a version of this that only allows them in Freeplay, but I don't speak for everyone.

Yeah, I made a mistake in assuming the restrictions on changing setup mid-round were handled elsewhere and this check was leftover from SRB2. I could make it auto-spectate you outside of free play like changing character does (and maybe extend this behaviour to changing follower/follower colour? ATM both of these can be changed mid-round unrestricted)

Making it FREE PLAY-only would be OK with me. Auto-spectating is handled by some changes indev already.

Didn't get around to it until now, but I've just pushed a commit which adds a M_NotFreePlay check in place of the previous P_PlayerMoving check. Let me know if I've gone about this incorrectly, I've only tested it in multiplayer with bots.

added 1 commit

• 9ed2b80c - Add M_NotFreePlay check to Color_OnChange

Compare with previous version