Fix custom gamedata mods crashing the game if loaded from commandline (Closes #473)

This was a serious issue so I had to throw this issue out of the window.

srb2fixcmdcgd.exe

Monster Iestyn gave me a clue on where the issue was and helped me fix it so credit goes to him for actually finding out the cause.

changed the description

This doesn't look like a comprehensive fix, I'm afraid. Although it fixes the case where only a savemoddata file is added, extra files may be added after the thing which would violate the savemoddata, even though it's set.

closed

marked as a Work In Progress

reopened

Ignore the comment from yesterday that I deleted tonight, because things are not going as planned this week.

added 1 commit

• f576ccf5 - Fixed crash, but a new bug has appeared

Compare with previous version

By the way, the new bug is that files listed after a custom gamedata mod won't mark the game as modified. I need to fix this bug before I can make merge request no longer WIP.

added 2 commits

• 42d98bf1 - Revert "Fixed crash, but a new bug has appeared"
• 78ec5b9f - Fixed gamedata corrupt crash correctly this time

Compare with previous version

unmarked as a Work In Progress

changed the description

This merge request should now be finished since I fixed the bugs with adding files through -file completely that were caused by G_SetGameModified being called too early.

I'm closing this cause a better solution was already made by Sphere.

closed

To be honest, I'm not sure which solution is better. This branch didn't look bad, although gamemodstate could've just been a boolean with the assignment in deh_soc.c removed.

My solution was redundant, because gamemodstate is unnecessary due to the existence of modifiedgame.