Possible netgame quit crash hotfix

This possibly fixes #487 (closed), it seems that the game does not properly flag "revert" strings of consvars as not allocated in zone memory anymore when it frees them to set a new value. And if that new value is not in zone memory, it then tries to free that and possibly comes up with the "wrong id" error as a result.

This is all just my guesswork though, I haven't actually tested this fix out yet so I don't know if it works.

merged

mentioned in commit 1e394a80

I've been working with this codebase for six years now and it still manages to surprises me. What the hell is a "revert" property for a cvar, when did this get added, and how did I never come across it while doing all the work I did for 2.2??? (Nice fix by the way.)

@toaster That field was introduced in !1179 (merged)

Thank you ^u^ Some delightful evening reading to get myself acquainted with...

Yeah, that was added half a year ago by !1179 (merged), as a way to make CV_SAVE a viable option for most of the netgame cvars.

I think it would be wise to get rid of that overcomplicated string/zstring (useless) optimisation and simply allocate the string regardless of whether the cvar's value is set to default or not.

I take it someone tested it out and it worked then? (Just logging in to see what's up before I sleep) If so, awesome.

Nope, it keeps happening

@MonsterIestyn ZDEBUG pretty much accused the line you wrote the fix for, but I guess it wasn't enough