Allow obtaining ring, time & grade emblems in regular gameplay

To-do:

• Actually test if the NiGHTS time/grade stuff fully works, because the mare stuff is a mess. Both seem to work in special stages, at least
• Update the player's best time/rings/grade in mainrecords/nightsrecords if an emblem is obtained this way
• Check for usedCheats instead of modifiedgame once !1749 (merged) is merged

Doesn't keep track of score emblems, because score carries over between levels, and score emblems are kinda lame anyway. Also doesn't actually record any replays or ghosts. Would be nice, but also makes this much more complicated, so I'm not gonna bother with that for now.

Sal edit: Score emblems and Coop are now supported. Score emblems use the score gained from when you last spawned, rather than global Coop score. A possible improvement would be to put this score on the intermission screen somewhere.

added Enhancement label

changed the description

changed the description

Concern: This would let you earn those emblems as Sonic & Tails (or while Super).
(But for the latter, it takes time to get enough rings for that, and it would drain rings too, so it might not be "helpful" for time/ring emblems (unless lots of rings are along the fastest path for time emblems).)

Concern 2: How does this interact with Pandora's Box? E.g. can you give yourself 999 rings or destroy all enemies, and still get emblems? I don't know which things in it "modify" the game. Edit: All Pandora's Box cheats "modify" the game, so this isn't a concern.

1. I think allowing Sonic & Tails to get record emblems is fine, especially if custom characters will eventually also be able to get them. In any case, Record Attack & NiGHTS Mode still exist for getting 100% "legitimate" records, without the assistance of Tailsbot.

2. The usage of any cheats will mark the game as modified (or as 'cheated', once !1749 (merged) gets merged), and the record emblems are only rewarded in unmodified/uncheated Single Player gameplay. (Also, Pandora's Box only unlocks with all 200 emblems in base SRB2... but it's a valid concern for mods that unlock it earlier.)

2. The usage of any cheats will mark the game as modified [...]

Also in Pandora's Box? ...Looking in the source code to check, yes, so that's okay.

mentioned in merge request !1749 (merged)

While I think this change is a good idea conceptually, I'm not sure how I feel about disregarding the score part. I'm imagining a player being amazed that they beat the Metal Sonic boss in a save file (or no-save mode) without getting hit, then disappointed that they didn't earn a score emblem at the end.

Oh right, kinda forgot about no-hit emblems technically being score emblems...

• Update the player's best time/rings/grade in mainrecords/nightsrecords if an emblem is obtained this way
• Check for usedCheats instead of modifiedgame once !1749 (merged) is merged

I'm not feeling so hot about this one, specifically updating best time in modified games. Considering best times aren't character-based at the moment, I would get really frustrated if my best Record Attack times got replaced because I was using a fast custom character (or a physics changing mod) in the "safety" of Singleplayer.

I can see your point about modified games.

However, I think it would also be frustrating if you get a new record in unmodified single player, possibly get an emblem for it, but not actually have the new best time/rings/etc. recorded anywhere. As the included gif shows, this is currently what happens, and at the very least I think the record should be saved if there's no prior record in gamedata.

Cosigning: I really think it's not a problem; you get the emblem saved, you should get the time saved too.

I agree that I absolutely don't want my best times automatically (and invisibly) overwritten if I casually load up SMS and boost through a level in single player. That's an absolute deal breaker. You shouldn't be able to accidentally overwrite vanilla time attack records in modified games.

I'm fine with gaining record attack emblems in modified games, but that would have to be decoupled somehow from the saved record. If that's too complicated or inelegant to do, I'd rather disable gaining record attack emblems in modified games in single player.

@spherallic

However, I think it would also be frustrating if you get a new record in unmodified single player, possibly get an emblem for it, but not actually have the new best time/rings/etc. recorded anywhere.

Oh no, unmodified singleplayer is fine. Also, are you saying what you're going for is if you already have the emblem, a new best time won't be recorded if it's faster than your current time?

added 1415 commits

• 53092526...13c30ace - 1414 commits from branch next
• 86b4f936 - Allow obtaining ring, time & grade emblems in regular SP gameplay.

Compare with previous version

Updated this branch to finish the todos, add score emblem support, and Coop support.

marked this merge request as ready

changed title from Draft: Allow obtaining ring, time & grade emblems in regular SP gameplay to Allow obtaining ring, time & grade emblems in regular gameplay

changed the description

approved this merge request

merged

mentioned in commit 1a209146

changed milestone to %2.2.12

mentioned in issue #1229