Fix use after free bug
1 unresolved thread
1 unresolved thread
Cherry-pick of KartKrew/Kart-Public!315 (merged)
Merge request reports
Activity
Filter activity
changed milestone to %2.2.11
added 7 commits
-
779012e7...d6640391 - 6 commits from branch
next
- 5913b297 - Fix use after free bug
-
779012e7...d6640391 - 6 commits from branch
- Resolved by Eidolon
added 24 commits
-
5913b297...67091009 - 23 commits from branch
next
- 5d0ba63a - Fix use after free bug
-
5913b297...67091009 - 23 commits from branch
3059 3059 mobj->player->viewz = mobj->player->mo->z + mobj->player->viewheight; 3060 3060 } 3061 3061 3062 if (mobj->type == MT_SKYBOX) 3063 { 3064 if (mobj->spawnpoint->options & MTF_OBJECTSPECIAL) 3065 skyboxmo[1] = mobj; 3066 else 3067 skyboxmo[0] = mobj; 3068 } 3069 - Comment on lines +3062 to +3069
This code would be drastically different for 2.2 codebase. 2.1 / Kart can only have one set of skybox viewpoint/centerpoint, whereas 2.2 stores 16 since there's an added Change Skybox linedef.
MTF_OBJECTSPECIAL
is also deprecated as of UDMF.Would look something like this, haven't tested myself though:
3066 if (mobj->type == MT_SKYBOX) 3067 { 3068 if (mobj->spawnpoint->options & MTF_OBJECTSPECIAL) 3069 skyboxmo[1] = mobj; 3070 else 3071 skyboxmo[0] = mobj; 3072 } 3073 3066 if (mobj->type == MT_SKYBOX && mobj->spawnpoint) 3067 { 3068 mtag_t tag = Tag_FGet(&mobj->spawnpoint->tags); 3069 if (tag >= 0 && tag <= 15) 3070 { 3071 if (mobj->spawnpoint->args[0]) 3072 skyboxcenterpnts[tag] = mobj; 3073 else 3074 skyboxviewpnts[tag] = mobj; 3075 } 3076 } 3077 And then after all of the savegame mobjs have been unarchived:
skyboxmo[0] = skyboxviewpnts[0]; skyboxmo[1] = skyboxcenterpnts[0];
added Bug label
mentioned in commit f50e7f25
Please register or sign in to reply