Skip to content
Snippets Groups Projects

Minor interpolation fixes

Merged Eidolon requested to merge uncap-fixes into next

Precipitation interpolation, minecart jump marks, and caption pop-in.

Edited by Eidolon

Merge request reports

Checking pipeline status.

Approval is optional
Ready to merge by members who can write to the target branch.

Merge details

  • 1 commit and 1 merge commit will be added to next.
  • Source branch will be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Eidolon changed milestone to %2.2.11

    changed milestone to %2.2.11

  • Eidolon changed the description

    changed the description

  • Eidolon added 3 commits

    added 3 commits

    • 6c54af37 - Fix precip interpolation
    • add018cb - Interpolate minecart marks
    • b02707a4 - Adjust caption pop-in by tics instead of frames

    Compare with previous version

  • Lach approved this merge request

    approved this merge request

  • #900 (closed)... I think that with fpscap 35, captions have two pop-in states before settling on a third Y coordinate. With fpscap 60, it seems that the first state lasts for one frame, and the second state lasts for one tic. (Edit: More precisely, I think that the second state lasts until the first frame of the next tic; it seems that it updates state after the first frame of a tic, instead of before the first frame of the next tic.) The pop-in motion is still affected by frame rate, but less so than before. (It's also not interpolated between tics.)

    #906 is better, but not fixed. When moving with a constant speed, the minecart rail-switch arrow moves smoothly. But when accelerating, it teleports a little forwards each tic; it seems to interpolate based on its current speed, not based on its previous position (and just interpolating based on the latter would make it not interpolate on its first tic; tricky problem).

    #916 doesn't feel completely fixed either. Rain seems to fall smoothly with hundreds of frames per second (previously, it'd mostly be smooth, but I'd occasionally see a frame where it'd suddenly jump one tic back; now, I don't), but with fpscap 60, it still feels "jumpy". My best guess is that it now jumps one frame back (or "doesn't update") for one frame per tic, instead of jumping an entire tic back for one frame per tic?
    When a rain object changes sprite frame, it seems to use the previous sprite frame and position, but the new frame flags (i.e. translucency), for one frame of a new tic. This is most noticeable when the splash teleports from the ground to being a new rain droplet in the sky; the splash puddle becomes fully opaque for a frame. (This was the case before this merge request, too.)

    Edited by Zwip-Zwap Zapony
  • Contributor

    The teleporting behaviour on the minecart arrows has always been there, it's just in the nature of how minecarts accelerate: srb20076

  • merged

  • MascaraSnake mentioned in commit 32183d1e

    mentioned in commit 32183d1e

  • Zwip-Zwap Zapony mentioned in issue #906

    mentioned in issue #906

  • Zwip-Zwap Zapony mentioned in issue #916

    mentioned in issue #916

  • added Uncapped label

Please register or sign in to reply
Loading