Skip to content
Snippets Groups Projects

Fix buffer overflow when linedef type 415 executes

Merged Hanicef requested to merge Hanicef/SRB2Classic:fix-line-415-buffer-overflow into next

When linedef type 415 executes, there's a risk that the game segfaults or executes arbitrary code due to the lump that contains the script is not guaranteed to be NULL-terminated (in fact, I've found that that's rarely the case). The fix simply creates a temporary buffer to store the script in and adds a NULL-termination to it.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading