Skip to content
Snippets Groups Projects

Fix console binds incorrectly respecting keyboard layout

Merged Hanicef requested to merge Hanicef/SRB2Classic:fix-console-double-mapping into next

While attempting to diagnose #1174 (closed), I discovered another possibly related bug where the console key incorrectly uses the keyboard layout-mapped key when opening and closing the console. This bug can easily be triggered on a non-QWERTY keyboard by binding a button that maps to a different character than QWERTY keyboards do (for example, Z on an AZERTY keyboard). In that case, both the key on the QWERTY layout (bottom-left) and on the AZERTY layout (where W is on a QWERTY keyboard) would toggle the console.

This is fixed by simply ignoring ev_text events when toggling the console, causing it to always use it's QWERTY mapping as intended.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading