Skip to content
Snippets Groups Projects

Fix issues with custom pause menu binds

Merged Hanicef requested to merge Hanicef/SRB2Classic:fix-keybinding-layout-issues into next

This patch fixes issues where custom binds would incorrectly respect keyboard layout, similar to !2295 (merged). The two fixes involves:

  • If the menu button is bound to something that maps to a key, pressing the key that maps to it would also trigger that bind. This can be triggered on Dvorak by binding QWERTY B and pressing the layouted B (N on QWERTY) on the keyboard.
  • Changing keybinds now makes sure that it actually binds to the QWERTY layout instead of the native one. This is merely done as a precaution, since while ev_keydown should trigger first and thus prioritize QWERTY, I haven't yet confirmed if that's the case on all OSes yet.

Merge request reports

Pipeline #6572 passed

Pipeline passed for 4a72123f on Hanicef:fix-keybinding-layout-issues

Approval is optional

Merged by Alam Ed AriasAlam Ed Arias 3 months ago (Jan 10, 2025 3:38am UTC)

Merge details

  • Changes merged into with d5b205d9.
  • Deleted the source branch.

Pipeline #6573 passed

Pipeline passed for d5b205d9 on next

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading