Skip to content
Snippets Groups Projects

Suggestion: 2.2 camera changes backport

Merged Suggestion: 2.2 camera changes backport
TehRealSalt/SRB2:camera-backport into next
Merged Sal requested to merge TehRealSalt/SRB2:camera-backport into next
  • Very slightly less claustrophobic camera defaults
  • Changed camera settings are saved
  • Camera distance increases relatively with splitscreen & analog (splitscreen is x1.5'd so it looks proportional to the change in screen space, analog is x1.2'd so it matches the old hardcoded camera distance of 192 under the new settings)

These changes are kind of debatable because them not saving was an intentional decision before 2.2, and the camera being farther out could potentially clip more geometry where it previously didn't... still, thought I'd open this for consideration; it makes me less nauseous personally, and I'm pretty sick of mashing a bind every time I die. :V

Correct me if I'm wrong, but this should change the default even without adding to the cool config updater, because the cvars didn't have CV_SAVE before.

Hub @ https://github.com/TehRealSalt/SRB2/tree/camera-backport

Edited by Sal

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sal changed the description

    changed the description

  • Sal changed the description

    changed the description

  • mazmazz
    mazmazz @mazmazz_ ·
    Contributor

    I'm 100% in favor of removing the cvar auto-reset; it makes sense too to still reset cam_rotate.

    The default value changes are really nice, but I'd keep the old values for 2.1 due to possible clipping issues; see below for Internal issue. Maybe the actual # of problem cases is limited, but I'd elect to stay safe. Maybe @MonsterIestyn or @Nev3r can give their opinion on the value change; personally I'd recommend to revert to the old values.

    All else is fine. I'm happy to keep the splitscreen adjustment because it does play better, and the negative impact is less IMO because less users use splitscreen.

    And yes, per your described reasoning, these changes don't need to consider the config updater.

    image

    Edited by mazmazz
  • Sal
    Sal @TehRealSalt ·
    Author Contributor

    Yeah, I was told about that issue after I left my code access... :v

    I don't think there are actually THAT many NEW instances (the camera already clips a lot on stupid crap :U), but I'm 100% fine with reverting the default change if we can keep the rest.

    Maybe you guys would like Kart's noclip camera...? XP

    Edited by Sal
  • mazmazz
    mazmazz @mazmazz_ ·
    Contributor

    I'm also fine with taking your word for it :slight_smile: If MI doesn't object, I'll +1 too.

  • mazmazz mentioned in issue #38 (closed)

    mentioned in issue #38 (closed)

  • mazmazz
    mazmazz @mazmazz_ ·
    Contributor

    I passed this onto dev and they seem positive about the default changes. Absent further objections, I'll likely merge as-is.

  • mazmazz merged

    merged

  • mazmazz mentioned in commit 9525de2d

    mentioned in commit 9525de2d

Please register or sign in to reply