Skip to content
Snippets Groups Projects

2.1.22 patch requirements

    • Closed Issue created by mazmazz @mazmazz_

    It's getting clear that we need to respond to a few bugs, so here's my list to justify a .22 release:

    • Fix Doom Sounds playing at the wrong pitch/speed for a few users (described in !373 (closed), fixed in !375 (merged))
    • Fix player.awayviewmobj breaking due to commit 1cc8619c (GitHub merge)
      • Breaks the Subarashii isometric cam
    • Fix Acidic Alpines crash with player.awayviewmobj
    • Fix 64-bit OpenGL holes
    • Fix 64-bit OpenGL shield z-fighting

    Extras

    • Fix srb2home paths for some scenarios like exec blah.cfg, saveconfig blah.cfg
    • Fix some mod savegame weirdness.
    • Use '+' instead of '' for sprite frames in PK3
    • Replace exchndl.dll because it's too new for Vista. Find a version that's between .21's and .20's.
      • Relevant
      • Alternatively, bundle dbghelp.dll ourselves. Figure out licensing and dependencies for this. (Drmingw themselves bundle this)
      • Keep the exchndl.dll because Alam advises not to downgrade. Older exchndl.dll's will not work with our new builds. Therefore, just ask XP/Vista users to delete the DLL, and if crash triage is necessary, direct them to download the DLL as well as the dbghelp installer from Microsoft.
    • Check if APNG is being produced properly for Linux. Relevant to libpng12-0/libpng16-16 dependencies
      • APNG writing is blocked in Linux, ERROR: Couldn't create aPNG: this build lacks aPNG support.
    • Linux: Make symlink for /usr/games/SRB2/srb2 from /usr/games/srb2
      • ln -s /usr/games/SRB2/srb2 /usr/games/srb2
      • dh_link usr/games/SRB2/srb2 usr/games/srb2

    New Features

    • Controller hot-plugging. I just need to test with more than one controller, thanks to my friend for lending me a second one.
      • I don't think this will make it, because I want to follow Wolfy's lead on controller cleanup.
    • Addons menu? Would be nice; let's see if I get to it.

    Notes

    • In the release post, make clear that 64-bit is experimental (as I should have done at first) and also highlight the OpenGL hole bug. I don't expect this to be fixed for .22

    • Bundle SDL 2.0.9 once and for all because the sound bug is fixed. There may be some lingering weirdnesses from OpenGL but I suppose it's too late to turn back on those because of the source update.

    • Finally, highlight that sprites that use the \ backslash char cannot be used in PK3. This implicates player sprites. Recommend that they continue to use WAD. We don't know how to fix this. 2.2 uses a different character set that excludes backslash.

    12 of 13 checklist items completed · Edited

    Designs

      Child items ...

      2. Activity

      • mazmazz changed the description

        changed the description

      • mazmazz changed the description

        changed the description

      • mazmazz changed the description

        changed the description

      • toaster
        toaster @toaster ·
        Contributor

        Backslash char is easy to create a backup for; add a hack in r_things.c's frame-identifying code to redirect a character that is not currently used, like +, to substitute for backslash. Maybe 15 minutes of work and 45 minutes of testing. If you still need this in two weeks' time, I'll make the MR myself.

      • Monster Iestyn
        Monster Iestyn @MonsterIestyn ·
        Contributor

        APNG is a difficult cactus to touch, I've known that for a while now. Apparently Windows relies on an old version of libpng with the APNG patch, simply because it allows us to make some hacks to have APNG recording at all! In later versions, the hacks we use are tinkering with what is considered "private" info now, preventing the hacks from being compiled.

        See the libpng-version-support branch for my attempts at fixing related errors to do with APNG. Sadly the hack I refer to I cannot do much about unless I can rewrite APNG recording to not need hacks altogether.

      • mazmazz
        mazmazz @mazmazz_ ·
        Author Contributor

        One way to "fix" the 64-bit OpenGL holes is to rebuild the nodes. I'll consider loading patch.dta with rebuilt maps to resolve the issue.

        I'll use the bug topic to encourage reports and also to see how widespread is the problem in addons. Will work on this week.

        EDIT 2: The below isn't a universal solution. Will elect to fix the code.

        EDIT: glbsp fixes the missing triangles without causing Software slime trails.

        • -maxblock 64000 must be specified; default is 16000 which fails BLOCKMAP collision in GFZ2.
        • -v3 must be specified; or else glbsp does not save SEGS or SSECTORS for large maps like ERZ2
          • (without -v3, forces -v5 for large maps, which saves in ZDoom nodes format)
          • Notably, ERZ2 has a significant slime trail with glbsp. srb20011 srb20009

        Recommendation until the GL code is fixed:

        • Use Zennode unless it breaks in 64 OGL; this works fine in most cases.
        • If 64 OGL breaks, use GLBSP and check for slime trail
        • If GLBSP produces slime trail, then use Zennode and adjust the vertexes to ensure convex triangles can be produced by BSP. See info on "polyginization". The vertexes should only need to be adjusted where missing triangles are found.

        image

        Edited by mazmazz
      • Sryder
        Sryder @Sryder ·
        Contributor

        I know the OpenGL holes appear in a few maps in Kart (Or at least did in the past, not so sure about now). When I looked into the issue I couldn't find a discernable reason for them to be happening. If I recall correctly, setting a breakpoint after the subsector was drawn showed the subsector info being off, but setting it just before showed it being fine. Something weird is definitely up with it.

      • mazmazz
        mazmazz @mazmazz_ ·
        Author Contributor

        Where would the breakpoint lines be? I haven't looked at the render code before, but I'm curious to see.

      • mazmazz mentioned in issue #40 (closed)

        mentioned in issue #40 (closed)

      • SteelT
        SteelT @SteelT ·
        Owner

        The bug with awayviewmobj was fixed here. https://github.com/STJr/SRB2/pull/367 Although yet to be merged still

        Edited by SteelT
      • mazmazz marked the checklist item Fix player.awayviewmobj breaking due to commit 1cc8619c (GitHub merge) as completed

        marked the checklist item Fix player.awayviewmobj breaking due to commit 1cc8619c (GitHub merge) as completed

      • mazmazz marked the checklist item Fix srb2home paths for some scenarios like exec blah.cfg, saveconfig blah.cfg as completed

        marked the checklist item Fix srb2home paths for some scenarios like exec blah.cfg, saveconfig blah.cfg as completed

      • mazmazz changed the description

        changed the description

      • mazmazz marked the checklist item Fix Doom Sounds playing at the wrong pitch/speed for a few users (described in !373 (closed), fixed in !375 (merged)) as completed

        marked the checklist item Fix Doom Sounds playing at the wrong pitch/speed for a few users (described in !373 (closed), fixed in !375 (merged)) as completed

      • mazmazz changed the description

        changed the description

      • mazmazz changed the description

        changed the description

      • mazmazz marked the checklist item Use '+' instead of '' for sprite frames in PK3 as completed

        marked the checklist item Use '+' instead of '' for sprite frames in PK3 as completed

      • mazmazz marked the checklist item Linux: Make symlink for /usr/games/SRB2/srb2 from /usr/games/srb2 as completed

        marked the checklist item Linux: Make symlink for /usr/games/SRB2/srb2 from /usr/games/srb2 as completed

      • mazmazz changed the description

        changed the description

      • mazmazz marked the checklist item Replace exchndl.dll because it's too new for Vista. Find a version that's between .21's and .20's. as completed

        marked the checklist item Replace exchndl.dll because it's too new for Vista. Find a version that's between .21's and .20's. as completed

      • mazmazz changed the description

        changed the description

      • mazmazz marked the checklist item Fix 64-bit OpenGL shield z-fighting as completed

        marked the checklist item Fix 64-bit OpenGL shield z-fighting as completed

      • mazmazz
        mazmazz @mazmazz_ ·
        Author Contributor

        I motion to release 2.1.22 really soon. The new features on the merge board are exciting, yet I don't want to spend another week deliberating on the new stuff while holding back the stability fixes.

        I'm also planning an extended break really soon, so we can go two ways:

        1. Get this done before Friday, when I leave (this is not a release date); or
        2. I leave anyway, y'alls figure out the rest, and ping me when it's time to do release builds.

        If we move to release, it looks like the included features will be:

        Likely to be merged

        New features, less likely to be merged

        If any of these get to +2 -- for good reason and if they're tested to satisfaction -- then they can go in. The rest can go in a future release.

        Merged

        Major Impact

        Crashes

        • !377 (merged) Awayviewmobj sanity checks; fixes KIMOKAWAII stage crash
        • GH!367 Fix remote viewpoint cameras; fixes SUBARASHII special stage camera

        Editing

        Renderer

        Program

        Edited by mazmazz
      • SteelT
        SteelT @SteelT ·
        Owner

        maz seems to have accidentally used the wrong link for automap fix PR

      • mazmazz closed

        closed

      Please register or sign in to reply