Gametype fixes

• Fixes Pink Shield not being awarded in friendly gametypes that weren't Co-op.
• Fixes player being reset in friendly gametypes that weren't Co-op.
• Prevents skin restriction in friendly gametypes.
• Fixes Emerald Hunt not working with the Emerald Hunt gametype rule.
• Fixed countdown time-up in not working in campaign gametypes that weren't Co-op.
• Fixes Hide and Seek.
• Score adding and stealing checks the gametype's rules.
• Exiting movement was changed to run in any friendly gametype.
• int_none intermission screens are skipped.

Needs testing.

changed the description

added 7 commits

• 51c593e6 - Fix homing ring using the wrong team gametype rule
• 3ce4ddf8 - Fix incorrect team gametype rule being used in A_OldRingExplode
• fd062308 - Score adding and stealing should check the gametype's rules.
• d3ed5ad4 - Race is Competition without the lives
• 6fb5a6ef - Consider hide-and-seek as GTR_HIDEFROZEN
• 4e7b4744 - G_CoopGametype, for all the GT_COOP cases
• 7d77600e - Make exitmove friendly, don't start empty intermission screens

Compare with previous version

changed the description

added Enhancement Gametypes labels

Branch has merge conflicts. Would love to plusone this but can't until sorted

I want to to point out something regarding this change:

• "Score adding and stealing should check the gametype's rules."

This is overall a good change since makes it so scripters don't have to track player score all the time. However, it also has the side effect of impacting gametypes which deliberately use the lack of auto-teamscore to its advantage. This isn't too big of a deal since GTR_TEAMFLAGS can also be used to the same effect, but GTR_TEAMFLAGS will also spawn the CTF Flags, which scripters may not want. If possible, I would prefer if the auto-teamscore feature was its own GTR_ setting.

Slightly more concerning is the fact that I was getting consistent segment violations when the game attempted to move onto the next map from the intermission screen. srb2gtr.RPT

changed milestone to %2.2.4

added 371 commits

• 7d77600e...60aa0f82 - 370 commits from branch next
• 39c5ab4e - Merge remote-tracking branch 'origin/next' into gtr-fixes

Compare with previous version

added 1 commit

• 38c74cec - Avoid a crash

Compare with previous version

changed milestone to %2.2.5

Is there a reason the milestone is 2.2.5 and not an earlier patch? Feels bizzare given the necessity of some of these bugfixes in order to use custom gametypes

We're trying to get 2.2.4 out today and this is too big for me to review right now. 2.2.5 doesn't have to be far off either.

Fair enough.

mentioned in merge request !920 (closed)

added 403 commits

• 38c74cec...207d8aee - 402 commits from branch next
• 067d9b9a - Merge remote-tracking branch 'origin/next' into gtr-fixes

Compare with previous version

merged

mentioned in commit 8c3e2728

mentioned in issue #172 (closed)

mentioned in merge request !1019 (merged)