cmake: Fix build errors related to test suite

See merge request STJr/SRB2!2070

This combined with the previous commit fixes building the test suite

James R. authored 2 years ago and SteelT committed 1 year ago

Fix for GCC C++ compiler, which always defines _GNU_SOURCE.

New M_Random implementation

See merge request !1780

Remove P_RandomFixed call when players are moving

See merge request STJr/SRB2!2057

Fix A_ConnectToGround's Handling of Scaled Mobjs

Closes #1038

See merge request STJr/SRB2!2029

Warn in console instead of hard erroring when attempting to modify a vanilla skincolor (resolves #1046)

Closes #1046

See merge request STJr/SRB2!2058

candelavla authored 1 year ago and Sal committed 1 year ago

Warn in console instead of hard erroring when attempting to modify a vanilla skincolor (resolves #1046)

Fix use-after-free when calling v.drawString in Lua

See merge request STJr/SRB2!2005

Fix softlocking as Sonic & Tails when Player 2 has no name

See merge request STJr/SRB2!2056

Fix crash when P_ZMovement calls from Lua removes the object

See merge request STJr/SRB2!2054

Fix segfault when calling P_RemoveMobj from MobjCollide hook

See merge request STJr/SRB2!2041

Clean up and simplify zone memory allocation

See merge request STJr/SRB2!2059

Drawseg clipping optimized, from prboom-plus

See merge request STJr/SRB2!2067

Small renderhitbox fix

See merge request STJr/SRB2!2068

cmake: Add optional clang-tidy integration

See merge request STJr/SRB2!1849

Eidolon authored 2 years ago and Sal committed 1 year ago

clang-tidy performs static analysis over the compilation unit,
producing more comprehensive compile warnings than are normally
generated by the compiler. For example, it will trace branches in a
function to find the exact conditions in which a null dereference
can occur.

Note that this produces an absurd amount of warnings for our existing
C code, and significantly slows compile times. It is pretty effective
at its job though. I think it would be good to turn on by default for
upcoming C++ code.

Enable C++17, Catch2 unit testing

See merge request STJr/SRB2!1854

"Add some extra randomization" is not how RNG works

Make reading and writing of all player stats to record attack demos precise (resolves #1048)

Closes #1048

See merge request STJr/SRB2!2045

Allow Record Attack in modified games

See merge request STJr/SRB2!2064

Co-authored-by: Sally Coolatta <tehrealsalt@gmail.com>

- Fix `lib_getSkinSprite` overshadowing `sprites` global
- Rename terrible result_e `ok` so it stops overshadowing crap
- Remove inlining from w_wad.c since it reached the inline limit (remember kids, your compiler knows better than you these days whenever or not to inline something)
- Remove unused variable in G_PlayerReborn

Add "drawonlyforplayer" and "dontdrawforviewmobj"

Closes #1009, #997, and #924

See merge request STJr/SRB2!2014

Don't allow loading demos with invalid file lists at all. If you insist on doing this, it has to be done from the command line now.