Skip to content
Snippets Groups Projects
Superstarxalien's avatar
commented on merge request !16 "Implemented PK3 deletion on incomplete processes; added error handling for sprites that go off bounds" at Kart Krew / kartmaker

okay, I'm pretty boneheaded for not realizing this right away, but the reason I used a macro over a function for this is because I'm using the SET_...

Eidolon's avatar
commented on merge request !16 "Implemented PK3 deletion on incomplete processes; added error handling for sprites that go off bounds" at Kart Krew / kartmaker

yeah, +1 on making it a function instead - no reason to use risky macros

Superstarxalien's avatar
commented on merge request !16 "Implemented PK3 deletion on incomplete processes; added error handling for sprites that go off bounds" at Kart Krew / kartmaker

oh I didn't even think about that. I could make it a function, if need be

Sal's avatar
commented on merge request !16 "Implemented PK3 deletion on incomplete processes; added error handling for sprites that go off bounds" at Kart Krew / kartmaker

Is there any particular reason for using a macro for this over a function?

Superstarxalien's avatar
opened merge request !16 "Implemented PK3 deletion on incomplete processes; added error handling for sprites that go off bounds" at Kart Krew / kartmaker
Eidolon's avatar
commented on issue #6 "Kartmaker names sounds incorrectly when prefix is shorter than 4 characters" at Kart Krew / kartmaker

Fixed in !15 (merged)

Togen's avatar
closed issue #6 "Kartmaker names sounds incorrectly when prefix is shorter than 4 characters" at Kart Krew / kartmaker
Eidolon's avatar
pushed to branch main at Kart Krew / kartmaker
Eidolon's avatar
accepted merge request !15 "Allow prefixes of less than 4 characters" at Kart Krew / kartmaker
Eidolon's avatar
approved merge request !15 "Allow prefixes of less than 4 characters" at Kart Krew / kartmaker
Superstarxalien's avatar
opened merge request !15 "Allow prefixes of less than 4 characters" at Kart Krew / kartmaker
Eidolon's avatar
pushed to branch main at Kart Krew / kartmaker
  • 7d12f58b · Add cJSON license to 3RDPARTY.txt
Eidolon's avatar
pushed to branch main at Kart Krew / kartmaker
  • 180d7668 · Reformat main.c according to clang format; update year to 2025
Eidolon's avatar
pushed to branch main at Kart Krew / kartmaker
Eidolon's avatar
accepted merge request !9 "Add editorconfig, clang-format files" at Kart Krew / kartmaker
Eidolon's avatar
pushed to branch main at Kart Krew / kartmaker
Eidolon's avatar
approved merge request !9 "Add editorconfig, clang-format files" at Kart Krew / kartmaker
Eidolon's avatar
commented on merge request !8 "Add CMake Build Script" at Kart Krew / kartmaker

We'd rather not use FetchContent. The two-file libraries like lodepng and miniz are designed purposefully to be included easily without dependency ...

Eidolon's avatar
closed issue #5 "kartmaker cannot be compiled on Windows using MinGW32/64" at Kart Krew / kartmaker