[next] Upwards current behaves differently

Under latest build of next, the upwards current in SunkSea X no longer works as intended, and forces the player downwards when jumping. The weird movement with Tails' tails is me attempting to jump.

2.1.10:

next:

added Bug Regression labels

Apparently the effect works fine when applied to an FOF, but not when applied to an in-level sector. Odd.

changed milestone to %2.2.11

added UDMF label

Figured out the cause: In 2.2.10, horizontal currents applied to in-level sectors require the player to touch the floor, but vertical currents don't. UDMF merged all current effects into one, so now vertical currents require floor touch as well.

I'm not sure how to handle this because currents are only supposed to be applied to water FOFs anyway. If you want a pusher effect in mid-air, use wind. If you want a pusher effect on the ground, use conveyor belts. There's no reason why currents should act as a substitute for either. As far as SunkSea X goes, I think the creator accidentally applied the current effect to the target sector instead of the water FOF. I don't see how it could be intentional, since the water covers the entire height of the sector.

My preferred solution would be one of the following:

• Remove the floor touch check. This would fix the vertical current in this map, but it would have side effects in maps that use currents as fake conveyor belts for whatever reason.
• Disable the effect entirely for in-level sectors. Then this map and others like it would have to be fixed.

Opinions?

mentioned in merge request !1826 (merged)

mentioned in commit 6ad18e5a

closed with merge request !1826 (merged)