Update skin cvar from character select and compare against cvar when warping without a loaded file (resolves #1267, #1117, #1114, #1112)

Similar to !2156 (closed) but reimplemented in a way that also fixes #1267 (closed)

This fixes the following three regressions:

1. Warping to a map from the title screen set your skin to Sonic
2. Using the ingame level select set your skin to Sonic
3. It was impossible to switch to Sonic via devmode when in single player without manually changing the cvar first

I've tested forceskin in multiplayer and it still behaves as !2100 (merged) intended.

changed title from Update skin cvar from character select and compare against cvar when warping without character select (resolves #1267 (closed), #1117 (closed), #1114 (closed)) to Update skin cvar from character select and compare against cvar when warping without character select (resolves #1267 (closed), #1117 (closed), #1114 (closed), #1112)

changed the description

While #1112 (closed) is not a regression it it also fixed as of this MR so I added it to the pile.

Is the player's selected default skin as chosen in the multiplayer player setup menu still respected despite the change to this line?

yeah

added 1 commit

• e2e879a7 - handle file loading correctly

Compare with previous version

changed title from Update skin cvar from character select and compare against cvar when warping without character select (resolves #1267 (closed), #1117 (closed), #1114 (closed), #1112 (closed)) to Update skin cvar from character select and compare against cvar when warping without a loaded file (resolves #1267 (closed), #1117 (closed), #1114 (closed), #1112 (closed))

changed milestone to %2.2.14

added Bug Regression labels

approved this merge request

merged

mentioned in commit 6d68091f

mentioned in merge request !2156 (closed)