P_IsPointInSubsector fix! (Most importantly: Knuckles No Longer In Space)

Now works in GL by not relying on stuff which GL mutates! Thanks for the guidance, @MonsterIestyn! Tested in Steel_Titanium's Nightlight Ruins (in SUGOI), which had the perfect testbed for plenty of Knuckles issues AND is one of the first maps out to the public which eschews thok barriers altogether in some sections.

• Knuckles climbing on one sided lines is now super great and doesn't allow any space-climbing at all, OGL-exclusive OR renderer-independent. I was able to restore my earlier perfect-in-Software fix because now it also works fine in GL, too!
• The devmode TELEPORT command now actually prevents you from going outside maps which don't have thok barriers near where you were. (It only prevented you from going outside maps with thok barriers because the thok barriers bled outwards and failed some other conditions.)
• Camera now behaves identically between Software and GL. (Look closely at p_user.c - I didn't modify any code in that section, but the chasecam DOES call P_IsPointInSubsector...)
• Here's a biggun - OpenGL precipitation is ALSO fixed! Yup. That's right. It used P_IsPointInSubsector too, and THAT'S why it was broken for all this time. (I did have to do a few other changes beyond just flipping the ifdef, but HOLY SHIT.) Tested this in Mystic Realm's second zone, which kept rain all the way through in OGL!!

(And yes, I AM compiling with OGL on for this branch.)

Added 1 new commit:

• 532c9334 - YUP, I just fixed OGL Precipitation with this branch too. What the fuck? Squashi…

https://twitter.com/toasterbabe/status/791779432897937408 HMMM considering its relevance to chasecam i now wonder whether this may have actually fixed some consfails tbph

Huh, would have thought camera stuff wouldn't cause many consfails since it's mostly client-side only... at least, I thought it was anyway.

But yeah wow, that workaround suggestion of mine actually works? awesome! (may want to check it out for myself tomorrow actually, but still)

Yup, although you did have two too many &dress pointerisations to use the line you originally suggested. :P

Oh right, whoops lol, I see what you mean.

I tested it and there doesn't seem to be any obvious side effects this time

One moment, making a new branch to clear the mess you reverted out of here...

Added 16 new commits:

• aa3e52f0 - Fix ANIMDEFS parsing to allow overwrite.
• cdb841ef - Only P_InitPicAnims when wads are loaded.
• dfc83a54 - Merge pull request #128 (closed) from Yukitty/fix-animdefs
• 8881a413 - Fixed that really annoying bug where you disappear when spindashing on top of a …
• fe67c6fb - Merge branch 'master' of http://git.magicalgirl.moe/STJr/SRB2.git into shield_issues
• 8025ef2f - At MI's suggestion (shields don't NEED to be tweaked, just overlays)
• 2ef1aaf1 - Merge branch 'shield_issues' into 'next'
• b8345aaf - Solid objects are now no longer selectively intangible on slopes.
• fa16abf7 - Fixed the thing where if you thok into a solid object you spin really fast in th…
• 0568712a - Prevent overflow when attempting to calculate the space between floor and ceilin…
• 8ad72232 - Helpful explanatory comments to assauge MI's fears.
• 6f1ce5c1 - Merge branch 'next' of http://git.magicalgirl.moe/STJr/SRB2.git into slopes_n_objects
• c42e7ee4 - Merge branch 'next' into slopes_n_objects
• 8b5abd95 - Merge branch 'slopes_n_objects' into 'next'
• ff443251 - P_IsPointInSubsector now works in both Software and GL, which means it can be us…
• ab6fd676 - YUP, I just fixed OGL Precipitation with this branch too. What the fuck? Squashi…

There. Rebased the branch on the current next and dropped the not working stuff you reverted. I reviewed all the final code beforehand and it looks quite stellar.

Status changed to merged

mentioned in commit 158db5d3

mentioned in issue #24 (closed)